[Typing][A-13] Add type annotations for paddle/tensor/to_string.py
#65042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jun 11, 2024
| edgeitems (int, optional): Number of elements in summary at the beginning and ending of each dimension, default 3. | ||
| sci_mode (bool, optional): Format the floating number with scientific notation or not, default False. | ||
| linewidth (int, optional): Number of characters each line, default 80. | ||
| precision (int|None, optional): Number of digits of the floating number, default 8. |
There was a problem hiding this comment.
话说这里现有的加空格比较好还是不加？（int|None 或者 int | None，个人倾向后者）
There was a problem hiding this comment.
其实吧 我觉得前面更好 ～ docstring 里面紧凑一点 ～
@sunzhongkai588 看你的了！😆
There was a problem hiding this comment.
我觉得前面更好 ～ docstring 里面紧凑一点 ～
+1！
There was a problem hiding this comment.
话说这里现有的加空格比较好还是不加？（
int|None或者int | None，个人倾向后者）
+1，这样还可以跟格式化对其
gouzil
changed the title
SigureMo
changed the title
paddle/tensor/to_string.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
Related links
@SigureMo @megemini