Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【complex op No.46】sin_coo/sin_csr(sparse) #62663

Merged
merged 20 commits into from
Jun 24, 2024

Conversation

bapijun
Copy link
Contributor

@bapijun bapijun commented Mar 12, 2024

PR Category

Operator Mechanism

PR Types

New features

Description

add complex support for sin_coo/sin_csr in sparse

#61975

Copy link

paddle-bot bot commented Mar 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 12, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 13, 2024
Copy link

paddle-ci-bot bot commented Mar 24, 2024

Sorry to inform you that 4314d6b's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link

paddle-ci-bot bot commented May 31, 2024

Sorry to inform you that 34054fa's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@bapijun
Copy link
Contributor Author

bapijun commented Jun 7, 2024

@luotao1 @zhiminzhang0830 @JiabinYang @phlrain
麻烦几个老师看一下,这个pr是在之前已经合入的一个pr基础上稍微加了一点东西
#62237

Copy link

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiminzhang0830
Copy link

对应的docstring也增加上支持了复数类型

@bapijun
Copy link
Contributor Author

bapijun commented Jun 13, 2024

对应的docstring也增加上支持了复数类型
这个也补充上去了

Copy link

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bapijun
Copy link
Contributor Author

bapijun commented Jun 16, 2024

@JiabinYang
@phlrain
也麻烦两位老师看一下代码

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 320d8c3 into PaddlePaddle:develop Jun 24, 2024
33 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
* 添加sparce 的复数

* 复数修改2

* empty for sparse

* 添加了abs进行测试

* 修改为define

* 修正了反向的bug

* 删除了比较用的abs

* 修改了单元测试 删除了测试单元测试

* 格式修改

* 格式修改

* change for switch

* bug fix for sparse sin

* add macro

* 把abs添加到宏里面去

* bug fix

* Remove extraneous code

* python doc string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants