This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
add some reduction PEs and python/C++ tests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
reviewed
Aug 21, 2020
cinn/common/test_helper.cc
Outdated
| @@ -52,5 +52,14 @@ cinn_buffer_t* BufferBuilder::Build() { | |||
| return buffer; | |||
| } | |||
|
|
|||
| cinn_buffer_t* CreateBuffer(const std::vector<int> shape, bool random, int set_value) { | |||
There was a problem hiding this comment.
set_value 是 int
是不是可以 template ?
template
cinn_buffer_t* CreateBuffer(const std::vector shape, bool random, T value=0.);
里面的 Type 可以用 type_of() 获取
https://github.com/Superjomn/CINN/blob/develop/cinn/common/type.h#L136
cinn/common/test_helper.cc
Outdated
| @@ -52,5 +52,14 @@ cinn_buffer_t* BufferBuilder::Build() { | |||
| return buffer; | |||
| } | |||
|
|
|||
| cinn_buffer_t* CreateBuffer(const std::vector<int> shape, bool random, int set_value) { | |||
| if (random) { | |||
| return common::BufferBuilder(Float(32), shape).set_random().Build(); | |||
There was a problem hiding this comment.
这里不一定是 Float(32)，也可能是 Int(32) 啥的
用上面的 template 可以自动推导
cinn/common/test_helper.cc
Outdated
| } else if (set_value != 0) { | ||
| return common::BufferBuilder(Float(32), shape).set_val(set_value).Build(); | ||
| } | ||
| return common::BufferBuilder(Float(32), shape).set_zero().Build(); |
There was a problem hiding this comment.
这个 helper 感觉不是必须的，BufferBuilder 目前应该也算比较方便了，而且灵活性比较好
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some reduction PEs and python/C++ tests(#138 )