Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo country > subdiv nested table #313

Merged
merged 12 commits into from
Sep 20, 2018
Merged

Conversation

sandikbarr
Copy link
Contributor

@sandikbarr sandikbarr commented Sep 18, 2018

#275 Geolocation table by country.

and to address #304

  • Loads nested subdivision data with filter router param

and per #279:

  • Adds a nested table component to show the nested subdivision data
  • Updates table design for recently added tables (User Agents and Geo Metro)
  • Updates table mobile design

and separately because metrics should stop doing this:

  • Remove effect that is loading all the selected podcasts episodes up front. This is not needed for now, and episode selection/loading will be addressed separately.

@sandikbarr sandikbarr self-assigned this Sep 18, 2018
@sandikbarr sandikbarr added this to the Sprint Quillan milestone Sep 18, 2018
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #313 into master will decrease coverage by 1.05%.
The diff coverage is 71.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   86.11%   85.06%   -1.06%     
==========================================
  Files         101      102       +1     
  Lines        2391     2517     +126     
  Branches      271      297      +26     
==========================================
+ Hits         2059     2141      +82     
- Misses        218      244      +26     
- Partials      114      132      +18
Impacted Files Coverage Δ
src/app/ngrx/reducers/index.ts 100% <ø> (ø) ⬆️
.../app/shared/nav/nav-menu-presentation.component.ts 96.87% <ø> (ø) ⬆️
src/app/ngrx/actions/castle.action.creator.ts 95.87% <ø> (ø) ⬆️
src/app/ngrx/reducers/router.serializer.ts 58.18% <0%> (-4.57%) ⬇️
src/app/ngrx/reducers/router.reducer.ts 100% <100%> (ø) ⬆️
...rc/app/ngrx/reducers/selectors/loaded.selectors.ts 100% <100%> (ø) ⬆️
...c/app/ngrx/reducers/selectors/loading.selectors.ts 100% <100%> (ø) ⬆️
src/app/shared/shared.module.ts 100% <100%> (ø) ⬆️
...rc/app/ngrx/reducers/selectors/router.selectors.ts 100% <100%> (ø) ⬆️
src/testing/downloads.fixtures.ts 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7150...a3999dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #313 into master will decrease coverage by 0.63%.
The diff coverage is 77.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   86.11%   85.47%   -0.64%     
==========================================
  Files         101      102       +1     
  Lines        2391     2520     +129     
  Branches      271      299      +28     
==========================================
+ Hits         2059     2154      +95     
- Misses        218      235      +17     
- Partials      114      131      +17
Impacted Files Coverage Δ
src/app/ngrx/reducers/index.ts 100% <ø> (ø) ⬆️
.../app/shared/nav/nav-menu-presentation.component.ts 96.87% <ø> (ø) ⬆️
src/app/ngrx/actions/castle.action.creator.ts 95.87% <ø> (ø) ⬆️
src/app/ngrx/reducers/router.serializer.ts 61.81% <0%> (-0.93%) ⬇️
src/app/ngrx/reducers/router.reducer.ts 100% <100%> (ø) ⬆️
...c/app/ngrx/reducers/selectors/loading.selectors.ts 100% <100%> (ø) ⬆️
src/app/shared/shared.module.ts 100% <100%> (ø) ⬆️
src/testing/downloads.fixtures.ts 100% <100%> (ø) ⬆️
src/app/ngrx/effects/routing.effects.ts 71.18% <100%> (+2.66%) ⬆️
src/app/ngrx/actions/action.types.ts 100% <100%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7150...a3999dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #313 into master will decrease coverage by 0.63%.
The diff coverage is 77.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   86.11%   85.47%   -0.64%     
==========================================
  Files         101      102       +1     
  Lines        2391     2520     +129     
  Branches      271      299      +28     
==========================================
+ Hits         2059     2154      +95     
- Misses        218      235      +17     
- Partials      114      131      +17
Impacted Files Coverage Δ
src/app/ngrx/reducers/index.ts 100% <ø> (ø) ⬆️
.../app/shared/nav/nav-menu-presentation.component.ts 96.87% <ø> (ø) ⬆️
src/app/ngrx/actions/castle.action.creator.ts 95.87% <ø> (ø) ⬆️
src/app/ngrx/reducers/router.serializer.ts 61.81% <0%> (-0.93%) ⬇️
src/app/ngrx/reducers/router.reducer.ts 100% <100%> (ø) ⬆️
...c/app/ngrx/reducers/selectors/loading.selectors.ts 100% <100%> (ø) ⬆️
src/app/shared/shared.module.ts 100% <100%> (ø) ⬆️
src/testing/downloads.fixtures.ts 100% <100%> (ø) ⬆️
src/app/ngrx/effects/routing.effects.ts 71.18% <100%> (+2.66%) ⬆️
src/app/ngrx/actions/action.types.ts 100% <100%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7150...438d001. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #313 into master will decrease coverage by 0.67%.
The diff coverage is 77.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   86.11%   85.44%   -0.68%     
==========================================
  Files         101      102       +1     
  Lines        2391     2514     +123     
  Branches      271      298      +27     
==========================================
+ Hits         2059     2148      +89     
- Misses        218      235      +17     
- Partials      114      131      +17
Impacted Files Coverage Δ
src/app/ngrx/reducers/index.ts 100% <ø> (ø) ⬆️
.../app/shared/nav/nav-menu-presentation.component.ts 96.87% <ø> (ø) ⬆️
src/app/ngrx/actions/castle.action.creator.ts 95.87% <ø> (ø) ⬆️
src/app/ngrx/reducers/router.serializer.ts 61.81% <0%> (-0.93%) ⬇️
src/app/ngrx/reducers/router.reducer.ts 100% <100%> (ø) ⬆️
...c/app/ngrx/reducers/selectors/loading.selectors.ts 100% <100%> (ø) ⬆️
src/app/shared/shared.module.ts 100% <100%> (ø) ⬆️
src/testing/downloads.fixtures.ts 100% <100%> (ø) ⬆️
src/app/ngrx/effects/routing.effects.ts 71.18% <100%> (+2.66%) ⬆️
src/app/ngrx/actions/action.types.ts 100% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7150...d7570ed. Read the comment docs.

@cavis cavis modified the milestones: Sprint Quillan, Sprint Robert Sep 19, 2018
@sandikbarr sandikbarr merged commit 5e0bb64 into master Sep 20, 2018
@sandikbarr sandikbarr deleted the feat/geo-country-subdiv branch September 20, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants