Skip to content

Conversation

@radical-ube
Copy link
Contributor

follows after #1386

This PR adds the scorecard dashboard to the Podcast overview page. There is some repurposing and moving of some already created views/queries/controllers, so some of this PR may appear to have larger changes than there actually are.

Some things to note, as this was in development:

  • the additional simultaneous querying was starting to produce errors from Clickhouse, so for development's sake, the Sparkline charts are turned off for this PR. this is a future task before release to revisit querying/caching efficiency/optimization.
  • there is some weird gradient behavior on the line charts that does not happen in the apex demo chart that remains to be explained. for now, lines will be in the solid blue until the reason is found.

@@ -1,11 +1,11 @@
.metrics-card-body {
height: 450px;
height: 275px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choosing an arbitrary number for development. this is used for the height of the chart card div wrapper, and needed a stable height consistent between the loading card and metrics card.

@@ -0,0 +1,56 @@
require "active_support/concern"

module MetricsQueries
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this concern never made it to main because it was part of the now-closed PR for the agents cards. so bringing it back again to save some lines and reuse common queries between Podcast and Episode. (and potentially Feed, for the next PR)

@@ -1,22 +1,25 @@
import { Controller } from "@hotwired/stimulus"
import { buildDateTimeChart, buildDownloadsSeries, LINE_TYPE } from "util/apex"
import { buildDateTimeChart, buildDownloadsSeries, LINE_TYPE, destroyChart } from "util/apex"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reusing this controller for the Episode Downloads card since it's the same purpose.

@@ -0,0 +1,24 @@
import { Controller } from "@hotwired/stimulus"
import { buildDateTimeChart, buildDownloadsSeries, BAR_TYPE, destroyChart } from "util/apex"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new controller for the Monthly Downloads chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants