-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/podcast scorecards dashboard #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @@ -1,11 +1,11 @@ | |||
| .metrics-card-body { | |||
| height: 450px; | |||
| height: 275px; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
choosing an arbitrary number for development. this is used for the height of the chart card div wrapper, and needed a stable height consistent between the loading card and metrics card.
| @@ -0,0 +1,56 @@ | |||
| require "active_support/concern" | |||
|
|
|||
| module MetricsQueries | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this concern never made it to main because it was part of the now-closed PR for the agents cards. so bringing it back again to save some lines and reuse common queries between Podcast and Episode. (and potentially Feed, for the next PR)
| @@ -1,22 +1,25 @@ | |||
| import { Controller } from "@hotwired/stimulus" | |||
| import { buildDateTimeChart, buildDownloadsSeries, LINE_TYPE } from "util/apex" | |||
| import { buildDateTimeChart, buildDownloadsSeries, LINE_TYPE, destroyChart } from "util/apex" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reusing this controller for the Episode Downloads card since it's the same purpose.
| @@ -0,0 +1,24 @@ | |||
| import { Controller } from "@hotwired/stimulus" | |||
| import { buildDateTimeChart, buildDownloadsSeries, BAR_TYPE, destroyChart } from "util/apex" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new controller for the Monthly Downloads chart.
follows after #1386
This PR adds the scorecard dashboard to the Podcast overview page. There is some repurposing and moving of some already created views/queries/controllers, so some of this PR may appear to have larger changes than there actually are.
Some things to note, as this was in development: