Transcode VBR mp3 files to CBR #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does lead me to wonder if we should just always transcode, rather than back and forth validating and conditionally fixing |
kookster
approved these changes
Dec 14, 2024
| @@ -25,6 +25,7 @@ def result | |||
| scope :copy_image, -> { where(type: "Tasks::CopyImageTask") } | |||
| scope :bad_audio_duration, -> { where("result ~ '\"DurationDiscrepancy\":([5-9]\\d[1-9]|[6-9]\\d{2}|[1-9]\d{3})'") } | |||
| scope :bad_audio_bytes, -> { where("result ~ '\"UnidentifiedBytes\":[1-9]'") } | |||
| scope :bad_audio_vbr, -> { where("result ~ '\"VariableBitrate\":true'") } | |||
There was a problem hiding this comment.
I saw the porter change to add this, smart.
| @@ -55,6 +56,10 @@ def bad_audio_bytes? | |||
| porter_callback_inspect.dig(:Audio, :UnidentifiedBytes).to_i > 0 | |||
| end | |||
|
|
|||
| def bad_audio_vbr? | |||
| !!porter_callback_inspect.dig(:Audio, :VariableBitrate) | |||
There was a problem hiding this comment.
hmm, we indifferent access the callbacks? nice
+1 I'm a big fan of !! for bools
app/models/tasks/copy_media_task.rb
Outdated
| @@ -58,7 +58,7 @@ def update_media_resource | |||
|
|
|||
| media_resource.save! | |||
|
|
|||
| if media_resource.status_complete? && (bad_audio_duration? || bad_audio_bytes?) | |||
| if media_resource.status_complete? && (bad_audio_duration? || bad_audio_bytes? || bad_audio_vbr?) | |||
There was a problem hiding this comment.
I think this is the only place we use these 3 bad_audio_*? methods, maybe combine into a single check, now that there are 4 conditions chained here? Purely aesthetic, this is fine!
| @@ -81,6 +85,16 @@ def slice_media! | |||
| end | |||
| end | |||
|
|
|||
| def next_highest_bitrate | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1109.
Requires PRX/Porter#164.
When a VBR file is uploaded, transcode it to CBR by running it back through Porter/ffmpeg.
Can be a bit slow, but better than having a misleading segmenter wavform.