Limit error interface #1122
Merged
Limit error interface #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove sync_blocks_rss from state flow
Fix for reset of non-drafting
Merged
svevang
requested review from
cavis,
kookster and
radical-ube
and removed request for
kookster and
radical-ube
cavis
approved these changes
Oct 31, 2024
Member
cavis
left a comment
cavis
left a comment
There was a problem hiding this comment.
Couple questions, making sure I understand what the nested rescues are doing. But looks good to me 👍
db/migrate/20241002215949_add_asset_processing_count_to_episode_delivery_status.rb
Show resolved
Hide resolved
cavis
approved these changes
Oct 31, 2024
Member
cavis
left a comment
cavis
left a comment
There was a problem hiding this comment.
Okay, making more sense after that rebase!
Looks good to me 👍 and good catch on the sync-blocks-rss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1016
Review #1116 before reviewing this PR