Consolidate bad audio logic

PRX · Dec 16, 2024 · 63c4c5b · 63c4c5b
1 parent da903f2
commit 63c4c5b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/models/task.rb b/app/models/task.rb
@@ -48,6 +48,10 @@ def job_id
   def source_url
   end
 
+  def bad_audio?
+    bad_audio_duration? || bad_audio_bytes? || bad_audio_vbr?
+  end
+
   def bad_audio_duration?
     porter_callback_inspect.dig(:Audio, :DurationDiscrepancy).to_i > 500
   end

diff --git a/app/models/tasks/copy_media_task.rb b/app/models/tasks/copy_media_task.rb
@@ -58,7 +58,7 @@ def update_media_resource
 
     media_resource.save!
 
-    if media_resource.status_complete? && (bad_audio_duration? || bad_audio_bytes? || bad_audio_vbr?)
+    if media_resource.status_complete? && bad_audio?
       fix_media!
     else
       slice_media!