Fix deploy dependency

PRX · Apr 22, 2024 · fd90c69 · fd90c69
1 parent 0222c80
commit fd90c69
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -23,6 +23,7 @@ jobs:
 
   deploy-application:
     runs-on: ubuntu-latest
+    needs: [check-project-std]
     steps:
       - uses: actions/checkout@v4
 

diff --git a/template.yml b/template.yml
@@ -23,6 +23,9 @@ Resources:
     Properties:
       Name: CloudTrail-org-sink
   OrgSinkEventBusPolicy:
+    # TODO Should have a Condition to limit this to events sent by events.amazonaws.com
+    # since it's only intended to get events from other event buses, not from
+    # any arbitrary sender
     Type: AWS::Events::EventBusPolicy
     Properties:
       EventBusName: !Ref OrgSinkEventBus