Update the form for ip optout #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kookster
commented
Nov 19, 2024
| @@ -107,6 +107,9 @@ Resources: | |||
| const email = params.get('inputEmail'); | |||
| const name = params.get('inputName') || 'Unknown'; | |||
| const organization = params.get('textOrganization') || 'Unknown'; | |||
| const type = params.get('messageType') || 'Unknown'; | |||
| const sourceIp = event.requestContext.http.sourceIp; | |||
| const userAgent = event.requestContext.http.userAgent; | |||
There was a problem hiding this comment.
We get the IP from the form, but I want to have and use the IP from the actual request, and the user agent as well, for reviewing the request.
kookster
commented
Nov 19, 2024
| @@ -107,6 +107,9 @@ Resources: | |||
| const email = params.get('inputEmail'); | |||
| const name = params.get('inputName') || 'Unknown'; | |||
| const organization = params.get('textOrganization') || 'Unknown'; | |||
| const type = params.get('messageType') || 'Unknown'; | |||
There was a problem hiding this comment.
I'm using this for both the contact and optout requests, so I introduced a type to specify that, mostly for including in the ZD ticket subject to know how to handle the request more easily
kookster
commented
Nov 19, 2024
| @@ -117,7 +120,7 @@ Resources: | |||
|
|
|||
| // Concat all form fields from the request as the ticket | |||
| // comment body | |||
| let comment = ''; | |||
| let comment = `sourceIp: ${sourceIp}\n\nuserAgent: ${userAgent}\n\n-----\n\n`; | |||
There was a problem hiding this comment.
Adding these at the top of the list of data in the ZD ticket body
kookster
commented
Nov 19, 2024
| @@ -129,7 +132,7 @@ Resources: | |||
| email, | |||
| name, | |||
| }, | |||
| subject: `Website form submission: ${organization}`, | |||
| subject: `Website form submission: ${type} - ${organization}`, | |||
There was a problem hiding this comment.
Added the type in here as well, so you can see immediately if this is a contact or optout message
farski
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goes with PRX/dovetail-marketing-site#34