Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router scaling #715

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Router scaling #715

merged 4 commits into from
Oct 12, 2023

Conversation

farski
Copy link
Member

@farski farski commented Oct 12, 2023

Closes #698

  • Updates S3 bucket config (already deployed)
  • Removes the bucket name from the EventBridge rule for triggering the scaler Lambda. This will now match on Object Created from any bucket, but we have EventBridge notifications turned on for very few buckets, and the likelihood of objects with these names being created in another bucket are pretty low. And even if we do get those false positives, we just scale up unnecessarily for a bit, which isn't really a problem.

@farski farski requested a review from cavis October 12, 2023 21:47
@farski farski self-assigned this Oct 12, 2023
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should leave 815 in there (for staging), but otherwise 👍

@farski farski requested a review from cavis October 12, 2023 22:01
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@farski farski merged commit fcb22cc into main Oct 12, 2023
4 checks passed
@farski farski deleted the router-scaling branch October 12, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dovetail router feed scaler not running in west-2
2 participants