Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Bump Boost to 1.81.0 #2940

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

Fuzzbawls
Copy link
Collaborator

@Fuzzbawls Fuzzbawls commented Oct 2, 2024

Bump the version of Boost we use to 1.81.0 for depends, and remove the Boost version specifier in macOS CI jobs. The current macOS CI jobs use a deprecated package [email protected], which has started to cause errors. That package is scheduled to be removed from brew.sh repositories in December, so instead of patching in compatibility for it (again), move on to the un-versioned Boost package.

Last commit was just added as GA updated the ubuntu-latest OS to Ubuntu 24.04, which has compile errors due to gcc 13, so for now we pin "latest" to 22.04.

@Fuzzbawls Fuzzbawls added this to the 6.0.0 milestone Oct 2, 2024
@Fuzzbawls Fuzzbawls self-assigned this Oct 2, 2024
Liquid369
Liquid369 previously approved these changes Oct 17, 2024
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 4fffec0

@Fuzzbawls Fuzzbawls dismissed Liquid369’s stale review October 17, 2024 21:11

The merge-base changed after approval.

Dot is used as a separator in versions of other depends packages.
Ubuntu 24.04 upgrades the gcc/g++ compiler to version 13, which
introduces some incompatibilities. Pin to 22.04 for now.
Copy link

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d3ff548
testing are passing again

Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK d3ff548

@Fuzzbawls Fuzzbawls merged commit d3c1e95 into PIVX-Project:master Oct 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants