Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] [DMNs] Split special transaction validation #2915

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

panleone
Copy link

First 4 commits are a (almost) move only refactor:
The self contained part of special transaction validation (i.e the part based only on specialtx info and not on full chain and masternode list) has been moved to functions IsTriviallyValid.

Last 2 commits improve unit test coverage:
I have added two files with a list of special txs which are either valid or invalid. Test consist in correctly deserializing the txs and verifying that valid/invalid ones are indeed considered valid/invalid.

@panleone panleone added this to the 6.0.0 milestone Mar 24, 2024
@panleone panleone self-assigned this Mar 24, 2024
Copy link
Member

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 607ba81

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 607ba81

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 607ba81

@Fuzzbawls Fuzzbawls merged commit d75c161 into PIVX-Project:master Mar 30, 2024
21 checks passed
@panleone panleone deleted the evo_special_tx_validation branch March 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants