[Scripts] Delete redundant util/fetch-params.sh #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
requested changes
Apr 22, 2023
There was a problem hiding this comment.
Suggested a change that makes the error message more modular and which would cover windows users (who natively cannot run bash shell scripts).
Also, don't submit any kind of manual changes to pivxstrings.cpp or any of the various .ts files as they will only be overwritten during the scripted translation process.
Liquid369
force-pushed
the
2023_fetch_params
branch
from
cffbbf5
to
2c73d25
Compare
Fuzzbawls
approved these changes
Jul 7, 2023
panleone
approved these changes
Jul 16, 2023
Fuzzbawls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously discussed fixing the
fetch-params.shscript, but after discussion its not actually used and is redundant.This script is broken and
install-params.shworks fine, so lets just remove it.