Make alert only show on the current wallet being synced#583
Open
Duddino wants to merge 4 commits intoPIVX-Labs:masterfrom
Open
Make alert only show on the current wallet being synced#583Duddino wants to merge 4 commits intoPIVX-Labs:masterfrom
Duddino wants to merge 4 commits intoPIVX-Labs:masterfrom
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Draft
JSKitty
approved these changes
Feb 6, 2026
Member
JSKitty
left a comment
There was a problem hiding this comment.
tACK 438e3c5
Tested the sync alert flow on the deploy preview:
- Imported a mnemonic, waited for sync -- alert appeared after sync completed.
- Created a second account -- alert fired for the new account once synced.
- Switched back to account 0 -- no unexpected alert. All three cases correct.
Claude Audit
Nit: dead .then(() => {}) in use_wallet.js:298
wallet.sync().then(() => {});
The empty .then() is a no-op leftover from before the alert moved to the Dashboard watch. Could just be wallet.sync();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Make the wallet synced alert only show when the current active wallet has been synced. (Previously the alert was bugged and not showing at all)
This required some changes:
lockableFunctions will now return theawaiting promise instead of immediately returningfalse, so differents part of the code can await the same function without calling it multiple timesWallet::synccan be called any time, but it will returnfalseif it has already been synced or there is no mkTesting