Open
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Usercs can now create voting groups, to select which masternodes they want to vote with.
They can either:
Groups will be saved in the db and show a % of voting weight, based on their number of masternodes.
If you do not select or create a group, you will automatically vote with the "All" group
Rationale
Some users, especially if they have a large amount of masternodes, care about the timestamp of votes, for privacy reasons. Or maybe they want to partially support a proposal they don't totally agree with (i.e. they could vote yes with 60% of the masternodes, no with 20% and abstain with the rest)
This PR allows a fine grained control over how many or which masternodes vote a proposal.
An alternative to this, was to use #542, but I believe that is not ideal, as you lose a lot of the control you would have with this PR, and also requires to backup each "Voting group" separately
Testing
TODO