Draft
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
This PR adds the ability to use
EscandEnterto interact with dialogs, effectively making them fully usable via keyboard only, which was not possible beforehand (i.e: you have to physically click any dialog buttons).This change will make it possible to, for example:
Open a Payment Invoice and pay it without needing any mouse input.
Unlock the wallet without mouse input.
Utilise the majority of other dialogs with only Tab + Enter + Esc.
Create hookable
keydownlistener to captureEsc/Enter.Apply universally to
confirmPopup.Apply to Vue Inputs (i.e: Password Dialogs, Send Dialog, etc).
Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
Esccloses it, and hittingEnterconfirms the dialog's action.If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!