Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill Patterns/Colors When Xml Attributes are Missing #4250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fill Patterns/Colors When Xml Attributes are Missing #4250

wants to merge 2 commits into from

Commits on Nov 30, 2024

  1. Fill Patterns/Colors When Xml Attributes are Missing 

    Fix PHPOffice#4248. PhpSpreadsheet has used what appear to be default attributes and tags when they are missing from Fill patterns and colors. However, Excel handles their absence a little differently from what the "default" would require. PhpSpreadsheet is changed to omit the attributes and tags in question when missing. This change is mostly targeted towards Xlsx read and write, but minor changes for Xls and Html write are also included.

This seems like it could be a breaking change, but I don't think it is. One test (DefaultFillTest introduced by PR PHPOffice#2050) must change, but the change is internal - loading and then saving the spreadsheet used in that change will appear the same after this change as it did before. Other differences are very likely to be bug fixes rather than breaks.
    @oleibman
    oleibman committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    dd69858 View commit details
    Browse the repository at this point in the history

  2. Scrutinizer

    @oleibman
    oleibman committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    eeef6dc View commit details
    Browse the repository at this point in the history