Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xlsx Reader Namespacing for Tables, AutoFilters #3668

Merged
merged 6 commits into from
Aug 10, 2023

Commits on Aug 3, 2023

  1. Xlsx Reader Namespacing for Tables, AutoFilters

    Fix PHPOffice#3665. The original issue was the use of an absolute path in the rels file pointing to the comments file. That was easy to take care of, but a bigger problem with the spreadsheet accompanying the problem report was that it used unexpected spacing for AutoFilters and Tables. AutoFilters were already known not to be covered, but Tables appeared after the namespacing changes, but without namespacing support. This PR fixes the absolute path problem and adds namespacing support for Tables and AutoFilters.
    
    Remaining areas which are still namespace unaware, mainly because of the absence of test samples which use them with unexpected namespacing, include conditional formatting (internal or external), sheet view options, sheet protection, unparsed loaded data, data validation (internal or external), alternate content, and header/footer images.
    oleibman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    cadb452 View commit details
    Browse the repository at this point in the history
  2. Mysterious Warning for Php7.4 Only

    Node no longer exists, doesn't affect result. Suppress warning.
    oleibman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    fe4b418 View commit details
    Browse the repository at this point in the history
  3. Scrutinizer

    What would a change be without some new false positives?
    oleibman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    12eeb1a View commit details
    Browse the repository at this point in the history
  4. Scrutinizer

    A gift that keeps on giving :-( Now it's deciding that things that it didn't report in a scan from a few minutes ago are worth reporting, even with no relevant code changes.
    oleibman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    5722800 View commit details
    Browse the repository at this point in the history
  5. Scrutinizer

    It is an idiot. Let me see if I can fix one false positive and succeed in guessing where it might report another one, even though it didn't do so with this last run.
    oleibman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    33ef0bd View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    9aeac76 View commit details
    Browse the repository at this point in the history