Skip to content

Commit

Permalink
Scrutinizer False Positives
Browse files Browse the repository at this point in the history
  • Loading branch information
oleibman committed Aug 20, 2023
1 parent d8bafbf commit 7400ba0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Reader/Xlsx.php
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ protected function loadSpreadsheetFromFile(string $filename): Spreadsheet
$xmlSheet->addChild('dataValidations');
}

foreach ($extlst->children(Namespaces::DATA_VALIDATIONS1)->dataValidations->dataValidation as $item) {
foreach ($extlst->/** @scrutinizer ignore-call */ children(Namespaces::DATA_VALIDATIONS1)->dataValidations->dataValidation as $item) {
$item = self::testSimpleXml($item);
$node = self::testSimpleXml($xmlSheet->dataValidations)->addChild('dataValidation');
foreach ($item->attributes() ?? [] as $attr) {
Expand Down
1 change: 1 addition & 0 deletions src/PhpSpreadsheet/Reader/Xlsx/ConditionalStyles.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ private function readConditionalsFromExt(SimpleXMLElement $extLst, StyleReader $
if ($extUri !== '{78C0D931-6437-407d-A8EE-F0AAD7539E65}') {
continue;
}
/** @scrutinizer ignore-call */
$conditionalFormattingRuleXml = $extlstcond->children($this->ns['x14']);
if (!$conditionalFormattingRuleXml->conditionalFormattings) {
return [];
Expand Down

0 comments on commit 7400ba0

Please sign in to comment.