Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader Word2007 : Support Header elements within Title elements #2674

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Reader Word2007 : Support Header elements within Title elements #2674

merged 2 commits into from
Jan 22, 2025

Conversation

SpraxDev
Copy link
Contributor

@SpraxDev SpraxDev commented Sep 12, 2024 •
edited by Progi1984
Loading

Description

We encountered issues with a Word document where this is a valid combination.
This fixes parsing the document properly.

Fixes #2616
Fixes #2426

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes Does not apply
  • I have updated the changelog

@SpraxDev
Copy link
Contributor Author

SpraxDev commented Sep 12, 2024 •
edited
Loading

Is a test case needed for this kind of change?
Do you have a recommendation on where to put it?

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Coverage Status

coverage: 96.95%. remained the same
when pulling 890f655 on SpraxDev:fix/support-header-within-title
into 136f549 on PHPOffice:master.

@SpraxDev SpraxDev marked this pull request as ready for review September 12, 2024 16:57
@SpraxDev SpraxDev force-pushed the fix/support-header-within-title branch 2 times, most recently from 1a1db6c to 4c7aaeb Compare September 13, 2024 14:22
Progi1984
Progi1984 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpraxDev Could you fix the changelog and rebase your PR ?

The PR is valid ✔️. Tested and (nearly) approved.

@Progi1984 Progi1984 mentioned this pull request Jan 22, 2025
Closed
2 tasks
@Progi1984 Progi1984 linked an issue Jan 22, 2025 that may be closed by this pull request
IOFactory::Load fails with "Cannot add Title in Header." #2616
Closed
2 tasks
@SpraxDev SpraxDev force-pushed the fix/support-header-within-title branch from 4c7aaeb to 890f655 Compare January 22, 2025 15:52
@SpraxDev
Copy link
Contributor Author

Sure @Progi1984, I've updated the changelog and rebased the branch ^^

@Progi1984 Progi1984 added this to the 1.4.0 milestone Jan 22, 2025
@Progi1984 Progi1984 changed the title fix: Support Header elements within Title elements Reader Word2007 : Support Header elements within Title elements Jan 22, 2025
@Progi1984 Progi1984 merged commit 21ac083 into PHPOffice:master Jan 22, 2025
30 checks passed
@Progi1984
Copy link
Member

Progi1984 commented Jan 22, 2025 •
edited
Loading

Thanks @SpraxDev for your contribution.

@Progi1984 Progi1984 mentioned this pull request Jan 22, 2025
Closed
@SpraxDev SpraxDev deleted the fix/support-header-within-title branch January 22, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

IOFactory::Load fails with "Cannot add Title in Header." Cannot save a word document as PDF
3 participants
@SpraxDev @coveralls @Progi1984