Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TemplateProcessor] Fix 0 considered as empty string #2617

Closed
wants to merge 3 commits into from

Conversation

cavasinf
Copy link
Contributor

@cavasinf cavasinf commented May 30, 2024

Description

Fixes #2572

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented May 30, 2024

Coverage Status

coverage: 96.918%. remained the same
when pulling c6a9569 on cavasinf:patch-1
into feadceb on PHPOffice:master.

@adriansuter
Copy link

👍 Ready to be merged.

@Progi1984
Copy link
Member

@cavasinf Could you update the changelog, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 7, 2024
@dsuurlant
Copy link

We are running into this issue and it would be great to see this fix merged!

@cavasinf
Copy link
Contributor Author

cavasinf commented Oct 14, 2024

Sorry for the delay!
@Progi1984 I've added it to the BC Breaks part, as it will certainly change the behavior on other devs processor result.

@supernova-ws
Copy link

Sorry for the delay! @Progi1984 I've added it to the BC Breaks part, as it will certainly change the behavior on other devs processor result.

Hi! Is there any plan to merge it to main repo?

Thanks for a great library!

@4RSIM3R
Copy link

4RSIM3R commented Nov 8, 2024

so, when it will be merged?

@supernova-ws
Copy link

so, when it will be merged?

This workaround works for me: #2572 (comment)

@Progi1984
Copy link
Member

@cavasinf Could you add an unit test like in #2566 ? After that, it will be ok for merge

@Progi1984 Progi1984 linked an issue Feb 3, 2025 that may be closed by this pull request
@Progi1984 Progi1984 self-assigned this Feb 11, 2025
@Progi1984
Copy link
Member

Superseeds by #2748

@Progi1984 Progi1984 closed this Feb 12, 2025
@Progi1984 Progi1984 added this to the 1.4.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
7 participants