Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for multiple comments on the same text object. #2112

Closed
wants to merge 2 commits into from

Conversation

rodrigoq
Copy link
Contributor

Description

Fixes #2109

Changed AbstractElement->commentRangeStart and End for a collection (commentsRangeStart and End) that accepts multiple comments for same element.

For consistency in names maybe a rename is due for Word2007 Writer AbstractElement writeCommentRangeStart (and End) to writeCommentsRangeStart, since it now iterates over the collection, a plural could go, I didn't change it because there were many files and made the pull request more complicated to follow.

Checklist:

  • [ X ] I have run composer run-script check --timeout=0 and no errors were reported
  • [ X ] The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@Progi1984 Progi1984 added this to the 1.3.0 milestone Aug 14, 2024
@Progi1984
Copy link
Member

Superseeded by #2665

@Progi1984 Progi1984 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding two comments to same text only shows one
2 participants