Use one generic function for all shapes. #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use one function for all shapes.
|
I have already implemented this in my last commit. |
|
@Progi1984 can you have a look, and tell me if thats a good solution? I am using it, since it satisfies my requirements. |
|
@mhasanshahid Hi Could you merge develop branch of PhpPresentation in your branch, please ? Thank you |
Progi1984
requested changes
Jun 10, 2019
Yes I will do it on the weekend. Also I will be very happy if I see myself as a contributing member in the list of contributors. Thank you |
4 tasks
|
Superseeded by #848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one function for all shapes.