GH Actions: add markdown lint + QA jobs #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on and depends on #449: this PR adds two markdown specific jobs to the
validate
workflow to ensure code style consistency and execute various QA checks, like a broken link and check and duplicate link check.GH Actions: add new check for consistency in markdown files
This new check uses the NPM MarkdownLint-CLI2 package via the
DavidAnson/markdownlint-cli2-action
action runner from the same maintainer.It executes a loose check for consistency and some common errors.
Some of the more annoying rules/rules which could impact display of markdown files on GitHub have been disabled.
All necessary configuration is contained in the
.markdownlint-cli2.yaml
file.To run locally, install via:
... and then run via:
Includes a problem matcher which should allow for displaying the results inline in GitHub PR code review view.
Includes adding
node_modules
to the.gitignore
in case anyone would install these tools locally (to prevent them committing them).Refs:
GH Actions: add new check with additional QA for markdown files
While MarkdownLint is absolutely great for finding formatting issues, Remark offers some additional "rules" which are useful, such as checking that links and link definitions match up, verifying all used links work and some additional formatting checks which markdownlint just doesn't offer.
The rule configuration is contained in the
.remarkrc
file.Files/directories to be ignored can be listed in the
.remarkignore
file which supports glob syntax, like.gitignore
.Note:
.
-prefixed files and directories are excluded by default. To include those in the scan, they have to be passed explicitly on the command-line.To run locally, follow the same steps as per the GitHub actions workflow.
Note: the workflow contains a double-run of remark-lint to allow viewing the results both in a human readable way in the actions transscripts, as well as getting annotations for found issue in PRs.
Notes about the config:
The provided regex fixes that.
The provided config should prevent false positives for those.
Refs:
Additional (external) plugins included:
Suggested changelog entry
N/A
Related issues/external references
Loosely related to #244