FileSystem: Don't follow symbolic links when recursively deleting directories #12052
+139
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
FileSystem::RecursiveDeleteDirectory
function will no longer recurse through symbolic links.FileSystem::IsSymbolicLink
andFileSystem::DeleteSymbolicLink
functions have been added. TheFileSystem::IsRealDirectory
function has been removed since it was unused.Rationale behind Changes
Prevent accidental data loss e.g. when deleting folder memory cards.
Suggested Testing Steps
This needs testing on macOS and especially Windows, since it touches Windows API code and I've only tested it on Linux. Since this is modifying some fairly important code I want multiple core contributors to review it before it's merged.
Here's an example of how you could reproduce the issue on Linux/macOS:
Be careful that you don't e.g. symlink your home directory by accident while testing this, as you could lose all your data.