Skip to content
This repository was archived by the owner on Jan 25, 2026. It is now read-only.

Comments

feat(custom-page): migrate "Custom.xaml" to "Custom_CE.xaml"#173

Closed
wyc-26 wants to merge 1 commit intomainfrom
#1875
Closed

feat(custom-page): migrate "Custom.xaml" to "Custom_CE.xaml"#173
wyc-26 wants to merge 1 commit intomainfrom
#1875

Conversation

@wyc-26
Copy link

@wyc-26 wyc-26 commented Jan 10, 2026

PCL2-CE: PCL-Community/PCL-CE#2166
第一次写 csharp,勿喷

Copy link
Contributor

@ruattd ruattd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

配置文件迁移不是给缓存用的,ConfigService 也不是应该写这个东西的地方

用配置文件迁移迁这种复制一下就行的东西属于是高射炮打蚊子了...

@wyc-26
Copy link
Author

wyc-26 commented Jan 12, 2026

配置文件迁移不是给缓存用的,ConfigService 也不是应该写这个东西的地方

不仅仅是缓存,用户自定义的主页也是这个文件吧……
说说该放哪吧,还是说不该塞到 .Core

用配置文件迁移迁这种复制一下就行的东西属于是高射炮打蚊子了...

SharedJsonMigration:?

@ruattd
Copy link
Contributor

ruattd commented Jan 12, 2026

其实我觉得用户把 PCL 和 PCL CE 放同一个目录里还不想让主页文件同步是他们自己的问题,我们不应该管

就算真要给用户擦屁股,正确的解决方式也应该是把本地主页文件与在线文件的缓存分开放,而不是在龙猫的基础上继续堆史山

总之无论何种方式处理也不应该存在迁移需求

@ruattd
Copy link
Contributor

ruattd commented Jan 12, 2026

SharedJsonMigration:?

这个是未来预留,因为应该在不久之后 (寒假) 我就会给它添加更复杂的迁移了,目前只是暂时这么放着

@ruattd
Copy link
Contributor

ruattd commented Jan 13, 2026

根据 PR 作者在讨论群中的意见,暂且关闭该 PR,若后续有继续维护的需求可重新开启

@ruattd ruattd closed this Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants