Skip to content

Comments

chore(logger): async dispose#2484

Merged
tangge233 merged 4 commits intodevfrom
chore/log-dispose
Feb 23, 2026
Merged

chore(logger): async dispose#2484
tangge233 merged 4 commits intodevfrom
chore/log-dispose

Conversation

@tangge233
Copy link
Contributor

No description provided.

@pcl-ce-automation pcl-ce-automation bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: S PR 大小评估:小型 labels Feb 23, 2026
@pcl-ce-automation pcl-ce-automation bot added size: M PR 大小评估:中型 and removed size: S PR 大小评估:小型 labels Feb 23, 2026
Copy link
Contributor

@ruattd ruattd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么给 cancelToken 干掉了,直接不 cancel 了等自己结束吗😰

EDIT: 没事了,能跑就行,但是 cancelToken 没用了要不删彻底点

@tangge233
Copy link
Contributor Author

我寻思 CancellationToken 对象太大并且使用 CancellationToken 的话 Channel 里剩余的日志还需要额外处理,代码重复,不如直接查看是否结束和还有没有日志(

@pcl-ce-automation pcl-ce-automation bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Feb 23, 2026
@tangge233 tangge233 merged commit d54fb15 into dev Feb 23, 2026
2 checks passed
@pcl-ce-automation pcl-ce-automation bot added 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Feb 23, 2026
@tangge233 tangge233 deleted the chore/log-dispose branch February 23, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M PR 大小评估:中型 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants