Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for issue no #5 - Updated styling of cards on the main page #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rajkumawat01
Copy link

Following things are updated in the index.html (main page)

  1. Updated and Improve styling of cards on the main page.
  2. Replaced them with old cards with proper data.
  3. Added appropriate HTML and CSS styling to display cards in a grid format.

Improved styling (click on image to see it properly)

Screenshot 2021-10-04 223038

Screenshot 2021-10-04 220836

Updated look of the main page. (click on image to see it properly)

127 0 0 1_5500_index html (3)

@rajkumawat01
Copy link
Author

Is there any mistake in the pull request?

Please try to merge this pull request before others because I have made changes in index.html and currently if you merge other pull requests before mine that will create more conflicts in index.html as other contributors are creating new cards with their component name where cards are with old styling.

And as of now, the code is not updated. They might be copying old cards.

Should I resolve the existing conflict?

image

@palakg01
Copy link
Member

palakg01 commented Oct 6, 2021

Hey @rajkumawat01
A few changes required

  1. Github profile will not be provided by everyone so make that optional instead of adding it to each card
  2. Along with the main index.html also add your cards as a component so that we have your cards as a separate component in case the main UI is changed in future.
  3. Please attach screenshots showing your cards are responsive according to different screen sizes
    Please make these changes and resolve all conflicts.

@rajkumawat01
Copy link
Author

Okay got it. Just one doubt.

Should I directly remove the option for inserting a GitHub profile? or just comment it out so that whoever wants to show it can just remove the comment and insert his/her profile link there. Okay?

@palakg01
Copy link
Member

palakg01 commented Oct 6, 2021

Okay got it. Just one doubt.

Should I directly remove the option for inserting a GitHub profile? or just comment it out so that whoever wants to show it can just remove the comment and insert his/her profile link there. Okay?

Yes you can comment it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants