-
Notifications
You must be signed in to change notification settings - Fork 870
fix(server): switch to maintained watchtower fork #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The PR name check is failing with a |
|
Is this trusted? Who is Nicholas Fedor? |
|
Looks like we are using a deprecated action. It doesn't seem to be intermittent. |
The fork has 2.2k stars (original repo 24.2k stars, but it now says "This repository was archived by the owner on Dec 17, 2025. It is now read-only.") and is widely discussed in bugs as the alternative people are moving to containrrr/watchtower#2122 |
It's the same action we're using on outline-apps though, which was definitely working very recently. |
bc77bbc to
db19f85
Compare
|
The CI checks are now fixed. |
fortuna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to change the image, we should at a minimum introduce a redirector to allow for future migrations without disruption.
In any case, the right place to fix this is in the outline-apps repo, where the Manager lives. This location is deprecated. It was kept for backwards-compatibility. We might be able to delete it at this point.
I also opened OutlineFoundation/outline-apps#2699 which updates this in outline-apps. Although I think it would be a good idea to update it here too as long as this file still exists, since anyone who somehow ends up using this install script will otherwise have broken watchtower experience. #1684 has 9 👍, so people are hitting this in the wild. I don't think it's a good idea for us to introduce a redirector
|
Fix for #1684
containrrr/watchtoweris no longer maintained, and has a breaking issue at containrrr/watchtower#2122https://github.com/nicholas-fedor/watchtower is the new maintained fork the community is moving to.