Fix build script, fix shulker boxes, add shields #156
Conversation
Now correct sound, rotation fixed
|
Might revert Quilt to 0.26.0, beta version seems unnecessary |
Some parts of the shields working will require my upcoming PR for MultiItemLib Textures are still borked, fix currently unknown
Roadhog360
changed the title
|
Feel free to ask me to remove the self-attribution upon request, these changes are ultimately small so I'd understand. |
|
I'm also going to add ELYTRA back to Multi-Item-Lib as the Netherite Elytra registered as an elytra is causing a few issues, like cape still rendering and other checks for elytra failing. I'll fix this in MIL. I can make another PR for this and the MIL version bump if you push MIL to your maven |
Basically temporary compile the jar so maven is not needed to test the new changes. Elytra now extends ElytraItem and not ArmorItem, allowing for better compatibility. Instead we add stuff in so it is treated like armor by areas we want it to be. Loom updates needed for MixinExtras FOR SOME REASON THE DEBUG LAUNCHER NO LONGER WORKS It's due to the loom update, I tracked it down to that individual change, but it is needed for MixinExtras. I'll look into it soon. I'm tired and have been fighting with this stupid error for 2 whole freaking hours...
|
So I decided to temporarily place MIL in libs and load it as a jar dependency so you don't need to do any manual work to test the new changes. So all you need to do if you accept the changes, is to simply change the buildscript to use the maven again and delete the jar. I can do this from my end if you want, just pull 1.6.3 MIL into your Maven and lmk to fix the dep setup |
Also store the Identifier instances instead of making a new one every frame
| id 'com.oroarmor.general-gradle-plugin' version '1.2.3' | ||
| id 'com.oroarmor.minecraft-gradle-plugin' version '1.2.3' |
There was a problem hiding this comment.
| id 'com.oroarmor.general-gradle-plugin' version '1.2.3' | |
| id 'com.oroarmor.minecraft-gradle-plugin' version '1.2.3' | |
| id 'com.oroarmor.general-gradle-plugin' version '1.3.1' | |
| id 'com.oroarmor.minecraft-gradle-plugin' version '1.3.1' | |
| @@ -47,7 +47,7 @@ minecraftPublishing { | |||
| curseforgeId = "394120" | |||
| dependencies { | |||
| "multi-item-lib" { | |||
| version = "1.6.2" | |||
| version = "1.6.3" | |||
There was a problem hiding this comment.
| version = "1.6.3" | |
| version = "1.7.0" | |
|
|
||
| LivingEntityFeatureRendererRegistrationCallback.EVENT.register(((EntityType<? extends LivingEntity> entityType, LivingEntityRenderer<?, ?> entityRenderer, LivingEntityFeatureRendererRegistrationCallback.RegistrationHelper registrationHelper, EntityRendererFactory.Context context) -> { | ||
| if (entityRenderer.getModel() instanceof PlayerEntityModel || entityRenderer.getModel() instanceof BipedEntityModel || entityRenderer.getModel() instanceof ArmorStandEntityModel) { | ||
| registrationHelper.register(new NetheriteElytraFeatureRenderer<>(entityRenderer, context.getModelLoader())); | ||
| } | ||
| })); |
There was a problem hiding this comment.
Ah thanks for getting rid of this, it was pretty hacky
| @@ -39,9 +39,11 @@ | |||
| import net.minecraft.util.Lazy; | |||
|
|
|||
| public enum NetheriteElytraArmorMaterials implements ArmorMaterial { | |||
There was a problem hiding this comment.
I think we should try to remove this.
| public class NetheriteElytraItem extends ArmorItem implements FabricElytraItem { | ||
| import java.util.UUID; | ||
|
|
||
| public class NetheriteElytraItem extends ElytraItem implements FabricElytraItem { |
There was a problem hiding this comment.
Does repairing this with netherite still work or is it back to phantom membrane?
| modCompileOnly('com.github.CrimsonDawn45:Fabric-Shield-Lib:main-SNAPSHOT') | ||
| modImplementation "com.oroarmor:multi-item-lib:1.7.0" | ||
|
|
||
| modCompileOnly("com.github.CrimsonDawn45:Fabric-Shield-Lib:1.7.2-1.20.2") |
There was a problem hiding this comment.
Is this still being used?
|
I didn't notice you reviewed. I'll read soon, give me a day or two. |
|
I finished the review 5 days ago put forgot to actually send it. |
Now correct sound, rotation fixed