Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2800 +/- ##
==========================================
- Coverage 43.88% 7.72% -36.16%
==========================================
Files 133 133
Lines 6189 5888 -301
Branches 1655 1571 -84
==========================================
- Hits 2716 455 -2261
- Misses 3469 5432 +1963
+ Partials 4 1 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supernova AMO
TODO:
scenarioConfigshould be consolidated into less casesWhat was done
SwapXAMOstrategy into a generalized Algebra-based strategy.Test fixes and updates
Why this change
SwapXAMOimplementation was too specialized and was expecting ws / OS tokens in specific order. Also the strategy was named SwapX even though the pool engine underneath was AlgebraWhat isn't done
Code review suggestions
A couple of files have been moved still they should be compared with their old versions:
StableSwapAMMStrategywith theSonicSwapXAMOStrategyalgebraAmoStrategy.jswith theswapx-amo.sonic.fork-test.js