[MerklPB] Migrate PoolBoosterFactoryMerkl to Beacon Proxy

[clement-ux]

Summary

Migrates PoolBoosterFactoryMerkl from deploying immutable PoolBoosterMerkl contracts to the OpenZeppelin Beacon Proxy pattern with a new upgradeable PoolBoosterMerklV2 implementation. Upgrading a single beacon automatically upgrades all existing Merkl pool boosters — no redeployment, no re-delegation.

Architecture

PoolBoosterFactoryMerkl (plain contract, cheaply redeployable)
    │
    ├── inherits AbstractPoolBoosterFactory (shared tracking logic)
    │
    ├── references → UpgradeableBeacon (OZ Ownable, owned by multichainStrategist)
    │                    │
    │                    └── points to → PoolBoosterMerklV2 implementation
    │
    └── deploys OZ BeaconProxy(beacon, initData) via CREATE2
         └── each proxy delegates to beacon.implementation()

Upgrading: multichainStrategist calls UpgradeableBeacon.upgradeTo(newImpl) → all existing pool boosters instantly use the new implementation.

Changes

New: PoolBoosterMerklV2.sol

• Upgradeable pool booster behind BeaconProxy with Initializable + Strategizable
• Configurable: duration, campaignType, rewardToken, merklDistributor, campaignData
• bribe() restricted to factory / governor / strategist
• rescueToken() restricted to governor
• Uses acceptConditions() instead of isValidSignature (ERC-1271)
• uint256[50] private __gap for upgrade safety
• _setCampaignData validates length > 0
• Implementation locked via constructor() initializer {}

Refactored: PoolBoosterFactoryMerkl.sol

• Now inherits AbstractPoolBoosterFactory (shared pool booster tracking)
• Deploys BeaconProxy via CREATE2 instead of directly deploying PoolBoosterMerkl instances
• Factory receives raw initData (encoded initialize call) — no longer hardcodes constructor params
• Constructor takes (oToken, governor, centralRegistry, beacon) — no longer stores merklDistributor
• bribeAll() overridden with onlyGovernor
• removePoolBooster() overridden to revert when address not found
• computePoolBoosterAddress() predicts deterministic BeaconProxy address
• Removed: merklDistributor storage, setMerklDistributor() (now per-booster)
• Removed: duplicated tracking logic (uses inherited poolBoosters, poolBoosterFromPool, etc.)

Modified: AbstractPoolBoosterFactory.sol

• bribeAll(): external → public virtual (overridable, callable from subclass)
• removePoolBooster(): added virtual (overridable by factory)

Modified: IMerklDistributor.sol

• Added acceptConditions() function signature

New: 175_deploy_pool_booster_merkl_factory.js

1. Deploy PoolBoosterMerklV2 implementation
2. Deploy UpgradeableBeacon pointing to it, transfer ownership to multichainStrategist
3. Deploy PoolBoosterFactoryMerkl(oeth, multichainStrategist, registry, beacon)
4. Governance proposal: remove old factory, approve new factory in central registry

Preserved: PoolBoosterMerkl.sol

• Original V1 contract unchanged (still deployed on Sonic)

Test plan

• All 53 mainnet fork tests passing
• Beacon upgrade: deploy new impl → beacon.upgradeTo() → existing proxies use new logic
• Implementation contract locked against initialize() calls
• Duplicate AMM pool guard prevents double-creation
• removePoolBooster reverts when address not found
• Empty campaignData rejected on creation and via setCampaignData()
• computePoolBoosterAddress returns correct deterministic address
• bribeAll() respects exclusion list and executes bribes
• All setter, bribe, rescue, and access control tests pass

🤖 Generated with Claude Code