-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin theme content picker #7343
Closed
petedavis
wants to merge
3
commits into
OrchardCMS:feature/admin-theme
from
petedavis:AdminTheme-ContentPicker
Closed
Admin theme content picker #7343
petedavis
wants to merge
3
commits into
OrchardCMS:feature/admin-theme
from
petedavis:AdminTheme-ContentPicker
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content picker popup window is shown with a width of xs, which the pager layout was not ideal.
* Opens popup window at sm layout width by default, rather than xs * Wrapped the page in a bootstrap container and removed the fixed width of 640px * Removed CSS that was preventing admin theme font from working in the content picker. * Added icons for Select and Add Selected buttons * Fixed row layout of content title and select button when shown in xs responsive width
@@ -27,7 +27,7 @@ | |||
data-admin-url="@Html.Encode(Url.ItemAdminUrl(contentItem))" | |||
data-display-link="@Html.Encode(Html.ItemDisplayLink(contentItem))" | |||
data-published="@contentItem.VersionRecord.Published.ToString().ToLower()"> | |||
@Html.Link(T("Select").Text, "#", new { @class = "button select" }) | |||
<a href="#" class="button select"><i class="fa fa-check" aria-hidden="true"></i> @T("Select").Text</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't call .Text
</fieldset> | ||
@Html.Link(T("Add Selected").Text, "#", new { @class = "button addSelected"}) | ||
<a href="#" class="btn btn-primary addSelected"><i class="fa fa-plus" aria-hidden="true"></i> @T("Add Selected").Text</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Fixed by 5c519a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of #7263. Missing an icon for applying filters.