Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin theme content picker #7343

Conversation

petedavis
Copy link
Contributor

@petedavis petedavis commented Oct 23, 2016

Fixes most of #7263. Missing an icon for applying filters.

  • Improve responsive layout of pager for sm and xs sizes
  • Opens popup window at sm layout width by default, rather than xs
  • Wrapped the page in a bootstrap container and removed the fixed width of 640px
  • Removed CSS that was preventing admin theme font from working in the content picker.
  • Added icons for Select and Add Selected buttons
  • Fixed row layout of content title and select button when shown in xs responsive width

image

Content picker popup window is shown with a width of xs, which the pager layout was not ideal.
 * Opens popup window at sm layout width by default, rather than xs
 * Wrapped the page in a bootstrap container and removed the fixed width of 640px
 * Removed CSS that was preventing admin theme font from working in the content picker.
 * Added icons for Select and Add Selected buttons
 * Fixed row layout of content title and select button when shown in xs responsive width
@@ -27,7 +27,7 @@
data-admin-url="@Html.Encode(Url.ItemAdminUrl(contentItem))"
data-display-link="@Html.Encode(Html.ItemDisplayLink(contentItem))"
data-published="@contentItem.VersionRecord.Published.ToString().ToLower()">
@Html.Link(T("Select").Text, "#", new { @class = "button select" })
<a href="#" class="button select"><i class="fa fa-check" aria-hidden="true"></i> @T("Select").Text</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't call .Text

</fieldset>
@Html.Link(T("Add Selected").Text, "#", new { @class = "button addSelected"})
<a href="#" class="btn btn-primary addSelected"><i class="fa fa-plus" aria-hidden="true"></i> @T("Add Selected").Text</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@Skrypt
Copy link
Contributor

Skrypt commented Nov 29, 2016

Fixed by 5c519a1

@Skrypt Skrypt closed this Nov 29, 2016
@petedavis petedavis deleted the AdminTheme-ContentPicker branch November 29, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants