Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Theme - ContentPicker - Display and functionality issues #7263

Closed
rtpHarry opened this issue Oct 8, 2016 · 5 comments
Closed

Admin Theme - ContentPicker - Display and functionality issues #7263

rtpHarry opened this issue Oct 8, 2016 · 5 comments
Assignees
Milestone

Comments

@rtpHarry
Copy link
Contributor

rtpHarry commented Oct 8, 2016

Navigation > Menu > Content Menu Item > Browse

image

  1. Select button should be right aligned:
    image
  2. Spacing between last item and button
  3. All buttons need icons
  4. Pager styles are wrong:
    image
  5. Select single and Select Multiple UI both showing on a select single picker
@rtpHarry rtpHarry added this to the Orchard 1.11 milestone Oct 8, 2016
@rtpHarry rtpHarry self-assigned this Oct 9, 2016
@petedavis
Copy link
Contributor

Item 1 is because of this.

/* from orchard-content-items.less */
            @media (max-width: @screen-xs-max) {
                flex-direction: column-reverse;
            }

If the window was a few pixels wider by default it would appear as below. Is there another area that the classes .content-items .summary .properties is used? Looks like it could be removed if this is the only place that it applies?

image

This is with that media selector removed:
image

@petedavis
Copy link
Contributor

petedavis commented Oct 20, 2016

Just another note, is there an icon selected for use on a select button? The same icon will need to be used on the taxonomies parent term selector page:
image

@rtpHarry
Copy link
Contributor Author

@petedavis good work, if you want to carry on with this one and make a PR please go ahead, I have marked it assigned to me but I haven't begun any work on it yet.

The buttons do want icons. I have done some work in this area, I have notes ready for a full review to bring all of the icons in line. I put some initial docs here. I picked one common icon for each action based on usage already in place in the admin theme repo. I also have a big list of notes not published with buttons that use variations or non-standard icons which I hope to bring them all in line before the theme reaches dev branch. So it looks like they should have:

<i class="fa fa-check" aria-hidden="true"></i> @T("Select")

@petedavis
Copy link
Contributor

No probs I will fix a few of them. Also done some rearranging so the admin theme font and colors are used. It was also overwriting the font awesome font-family on icon elements. Page could probably do with a restructure to use a responsive grid layout rather than the current fixed width of 640px.

Currently there is no suggestion for "Apply" in the list. Check feels appropriate, but would clash with select?

Also I have reduced the font size of the metadata to try and ensure it is always in a single line.

image

@Skrypt
Copy link
Contributor

Skrypt commented Nov 29, 2016

fixed by 5c519a1
I reapplied @petedavis PR on a commit and made some tweaks on it just for the records.

@Skrypt Skrypt closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants