Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preference to share options between tools #1120

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Oct 14, 2024

Supersedes #989

  • Adds a Global tool option that enables sharing of common configs between the two tools. Sync is done whenever save_config() is called.

(Other necessary changes)

  • Flip/rotate options now get saved between sessions
  • Fill of the curve tool now gets saved between sessions

@OverloadedOrama OverloadedOrama changed the title Add Global option to share config between tools Add an option to share options between tools Oct 16, 2024
@OverloadedOrama OverloadedOrama changed the title Add an option to share options between tools Add a preference to share options between tools Oct 16, 2024
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, we thought it would be best to make this an option in the preferences instead of a button in the global tool options, as this is an option that will most likely not be toggled on and off very often. It's best to keep such options in the preferences to avoid cluttering the UI too much.

Thank you!

@OverloadedOrama OverloadedOrama merged commit 3863cba into Orama-Interactive:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants