test(e2e): Add easier troubleshooting steps for e2e-testing #20632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new buildroot docker container for updated buildroot requires you to do python3 instead of python in shell calls to the python interpreter. We need to use this new container because the old container can't be built anymore - the debian buster apt repos have been taken down because that distro release is out of support.
…ype changes (#20621) Similar to how we delete labwares created by a stacker fill step if that step is deleted, we should delete labwares created by a saved stacker fill step if that step is changed to empty, store, or retrieve.
… presentation (#20584) # Overview Add an additional size to `RobotInfoLabel` to acomodate stacker slot presentation and use .charAt() to only display stacker column <img width="752" height="677" alt="Screenshot 2026-01-15 at 11 40 18 AM" src="https://github.com/user-attachments/assets/c0d77f16-4dc9-489c-8aa3-a2dab9a7b54a" /> ## Test Plan and Hands on Testing <img width="297" height="324" alt="Screenshot 2026-01-14 at 4 16 45 PM" src="https://github.com/user-attachments/assets/aedba2e6-8ea3-44db-a186-a9ea38b242db" /> <img width="679" height="667" alt="Screenshot 2026-01-14 at 4 16 51 PM" src="https://github.com/user-attachments/assets/c8e8114e-3118-4772-a851-98850cbf8825" /> ## Review requests is using charAt() safe? ## Risk assessment - I adjusted a widely used component so medium risk, but with an additional case so everything else should be good Closes RQA-5014 and RQA-5020
# Overview Adding a user-facing description of this [known issue](https://opentrons.atlassian.net/browse/RQA-5023) to PD 8.8 release notes, plus a solution. ## Test Plan and Hands on Testing ## Changelog ## Review requests Does this make sense/cover this issue completely? ## Risk assessment low.
…sh (#20628) # Overview When migrating protocols, PD calls `getDefaultBlowoutFlowRate()` to fill in the blowout rate if it's not specified in the step. `getDefaultBlowoutFlowRate()` tries to look up the default blowout rate in the pipette specs' `supportedTips`, but sometimes the pipette specs don't have an entry for the tip that the step is using. In RQA-5047 in `multipleLiquids.json`, the protocol was trying to use the `p300_single_gen2` pipette with a `opentrons_96_filtertiprack_20ul` tip, but the pipette definition only has `supportedTips` entries for `t200` and `t300`, so we were crashing. It turns out that the code that calls `getDefaultBlowoutFlowRate()` is fine with the function returning null, so this PR just changes the function to return null if the blowout rate for the tip does not exist in the pipette definition. ## Test Plan and Hands on Testing Import `multipleLiquids.json` from RQA-5047. PD would crash before, and no longer crashes after this change. ## Risk assessment Low. The affected function is only used in migrations, for old protocols that didn't specify a blowout rate.
…0631) In starting deck state, we should set null both the stored labware details as well as the labware in hopper properties of the stacker.
add more intuitive troubleshooting steps for running local tests and make troubleshoot to show where failed tests break #20630
Contributor
Author
Example of new output of
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #20632 +/- ##
==========================================
+ Coverage 56.75% 56.92% +0.17%
==========================================
Files 3911 3912 +1
Lines 322837 322991 +154
Branches 45739 45751 +12
==========================================
+ Hits 183220 183857 +637
+ Misses 139399 138911 -488
- Partials 218 223 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
) # Overview Removes css width specifications to remove horizontal scroll bar and left aligns text in labware button ## Test Plan and Hands on Testing smoke tested: https://github.com/user-attachments/assets/e6597bdf-cfbd-492f-8862-c47130163beb ## Changelog - remove width specifics in css styling - left align text to match design ## Risk assessment low - cosmetic changes Closes RQA-5019
#20624) # Overview Enables deletion of labware in liquid modal ## Test Plan and Hands on Testing smoke tested deleting labware in deck and in a stack https://github.com/user-attachments/assets/49b73c4c-97f4-467f-a8f8-4cfec7de6f6a ## Changelog - added selected labware reassignment in `LabwareCardOverFlowMenu` to be the next available labware in the same stack - if there is no labware left in the stack it navigates back to the designer page ## Risk assessment effects use of `LabwareCardOverFlowMenu` but upon smoke testing, things seem fine moved some components into organisms to avoid circular dependencies. Closes RQA-5024 and created RQA-5050 to allow for multiple selection of labware to delete all at once.
alexjoel42
requested review from
TamarZanzouri
and removed request for
a team
skowalski08
reviewed
Jan 20, 2026
| "Staging": ("TEST_ENV=staging uv run pytest -m pdE2E", "make test-pd-staging"), | ||
| "Format": ("uv run ruff format --check .", "make format", "make format"), | ||
| "Lint": ("uv run ruff check .", "make lint", "make lint"), | ||
| "Typecheck": ("uv run mypy automation tests conftest.py", "make typecheck", "make typecheck"), |
Contributor
There was a problem hiding this comment.
Just double check if Format, Lint, and Typecheck should all have the second instance of 'make ...'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
make test-pd-localhas more instructions for how to resolve issuesmake troubleshootruns failed tests sequentially and will show you where they break in a paused stateIt can be hard to read a stack trace, this adds
make troubleshootwhich you can run afterTest Plan and Hands on Testing
Hopefully this doesn't negatively impact our CI/CD
Changelog
Review requests
I'd love some help on decision making for how to handle multiple failed tests gracefully
Risk assessment
Very low