fix(protocol-designer): remove flickering in timeline and fix distrib… #16901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
force-pushed
the
pd_fix-flickering-details
branch
from
dfa346c
to
81736b0
Compare
koji
reviewed
Nov 20, 2024
protocol-designer/src/assets/localization/en/protocol_steps.json
Outdated
Show resolved
Hide resolved
koji
reviewed
Nov 20, 2024
protocol-designer/src/assets/localization/en/protocol_steps.json
Outdated
Show resolved
Hide resolved
syao1226
reviewed
Nov 20, 2024
| </Flex> | ||
| </ListItem> | ||
| ) : null} | ||
| {dest != null ? ( |
There was a problem hiding this comment.
should we also remove the dest != null check on line 188 then?
There was a problem hiding this comment.
i think that is needed for when you consolidate, right? because you'll have only one dispense to many aspirates.
jerader
commented
Nov 21, 2024
Comment on lines
+123
to
+124
| "block": "<text>End with block at</text><tag/>", | ||
| "lid_position": "<text>and lid</text><tag/>" |
There was a problem hiding this comment.
recommended by Ed to shorten this
I think we need to format uppercase the DeckInfoLabel deckLabel translation, and omit liquid icon? |
ncdiehl11
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ute details
closes RQA-3630 RQA-3624
Overview
This PR does 2 things:
Test Plan and Hands on Testing
Create a protocol and make a distribute step: basically aspirate from 1 well and dispense into multiple wells and add a small volume like 10uL and the distribute path should be selectable. Then click "view details" on the step's overflow menu and see that it looks as expected with no extra blank list items
Then upload the attached protocol and hover through the steps in the timeline, see that there is no flickering
1.0 testing.json
Changelog
Risk assessment
low