Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): delete unused code #16869

Draft
wants to merge 6 commits into
base: edge
Choose a base branch
from
Draft

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 18, 2024

closes AUTH-645

Overview

Decide if we want to merge this in before the release or after the release

This PR deletes unused code and moves a few components into the correct folder (such as LabwareOnDeck, getUnusedEntities). There are also a few redux actions/selectors/reducers that were deleted because they are no longer in use. Those include:

  1. thermocycler profile step -> the redesign has it contained in a modal and keeps track of stuff via local states
  2. a bunch of hints -> we deprecated most of them for the redesign. only remaining hints are for exporting a protocol with unused hardware and changing your magnetic module version
  3. redux actions related to navigation -> we use react-router-dom now for navigation
  4. stuff related to expanding and collapsing steps and multi-steps -> we no longer allow expanding/collapsing steps at all

Additionally, all css style sheets are officially deleted 🗑️

Test Plan and Hands on Testing

Thoroughly smoke test.

Changelog

🗑️

Review requests

Risk assessment

medium - high, it deletes a bunch of code

@jerader jerader added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Nov 18, 2024
@jerader jerader changed the title start to delete unused code feat(protocol-designer): delete unused code pt1 Nov 18, 2024
@jerader jerader changed the title feat(protocol-designer): delete unused code pt1 feat(protocol-designer): delete unused code Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant