Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added mail sender as env #110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrebrito16
Copy link

Hello, I noted that when running on self hosted there is no way to change the sender email. This is a problem, cause resend will not allow the email from openpanel domain.

This is a simple fix, should added on docs soon.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2025

CLA assistant check
All committers have signed the CLA.

@lindesvard
Copy link
Contributor

Thanks a lot and this is great but two thing:

@andrebrito16
Copy link
Author

I ran a biome format, and this should be ok now. About the installation, can you tell-me the file where I should modify. What I have in mind is:

  1. Set domain
  2. A step asks for sender with default "openpanel@domain"
  3. Add to env

@lindesvard
Copy link
Contributor

Sorry for late reply! Have been ignoring github the last couple of weeks to focus on infra.

I ran a biome format, and this should be ok now. About the installation, can you tell-me the file where I should modify. What I have in mind is:

  1. Set domain
  2. A step asks for sender with default "openpanel@domain"
  3. Add to env

Add a new part here in this file https://github.com/Openpanel-dev/openpanel/blob/main/self-hosting/quiz.ts

I think this could be the final step. The question could be something like We use resend to send out emails (optional). Do you want to provide your api key?

Then we ask for the api key and from what email it should be sent as. The default email should be something like noreply@[the_domain_they_provided_in_the_first_step] (https://github.com/Openpanel-dev/openpanel/blob/main/self-hosting/quiz.ts#L178-L193)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants