Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some basic codestyling things #383

Merged
merged 8 commits into from
Aug 20, 2024
Merged

some basic codestyling things #383

merged 8 commits into from
Aug 20, 2024

Conversation

NinaHerrmann
Copy link
Contributor

@NinaHerrmann NinaHerrmann commented Jun 14, 2024

Two major style changes have been introduced in the Pull Request:

  • change the order of strings to alphabetically
  • move require_once('../../config.php'); after the use statements as, for some reason, the other order does not find the @copyright and @Licence tags.

Some minor changes, such as not exceeding 135 Characters per line, are also part of this pull request.
Adjusted batchupload_setting_desc to describe the feature not available in detail.

@NinaHerrmann
Copy link
Contributor Author

Fixes #380

@ferishili
Copy link
Contributor

ferishili commented Jun 19, 2024

Hi @NinaHerrmann
it seems that these changes are not compatible with the behat feature test for direct access, would you please take a look at that?

@ferishili ferishili merged commit 248a37d into master Aug 20, 2024
50 of 51 checks passed
@ferishili
Copy link
Contributor

due to an unexpected behavior from directaccess behat feature, it has been disabled in this PR

Copy link
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants