Fix Wimplicit-fallthrough warnings (#713)
#1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMS21
commented
Nov 5, 2023
src/xrPhysics/PHJoint.cpp
Outdated
| @@ -1255,7 +1261,7 @@ void CPHJoint::SetAxisSDfactorsActive(int axis_num) | |||
| case 0: | |||
| dJointSetSliderParam(m_joint, dParamStopERP, axes[0].erp); | |||
| dJointSetSliderParam(m_joint, dParamStopCFM, axes[0].cfm); | |||
| case 1: | |||
| [[fallthrough]]; case 1: | |||
There was a problem hiding this comment.
Is this correct? Or is this actually a missing break?
AMS21
commented
Nov 5, 2023
src/xrPhysics/PHJoint.cpp
Outdated
| @@ -563,7 +563,7 @@ CPHJoint::CPHJoint(CPhysicsJoint::enumType type, CPhysicsElement* first, CPhysic | |||
| axes.push_back(axis); | |||
| axes.push_back(axis2); | |||
| axes.push_back(axis3); | |||
| case slider: axes.push_back(axis); axes.push_back(axis); | |||
| [[fallthrough]]; case slider: axes.push_back(axis); axes.push_back(axis); | |||
There was a problem hiding this comment.
I guess this is correct but it looks very wrong to me :/
Xottab-DUTY
reviewed
Nov 5, 2023
Xottab-DUTY
reviewed
Nov 5, 2023
Xottab-DUTY
reviewed
Nov 5, 2023
Xottab-DUTY
reviewed
Nov 5, 2023
AMS21
force-pushed
the
warnings/implicit_fallthrough
branch
from
bfea56f to
b90c438
Compare
|
Fixed style issues :) |
AMS21
force-pushed
the
warnings/implicit_fallthrough
branch
from
b90c438 to
73d47a2
Compare
25 tasks
25 tasks
AMS21
force-pushed
the
warnings/implicit_fallthrough
branch
from
73d47a2 to
5e20cd3
Compare
AMS21
force-pushed
the
warnings/implicit_fallthrough
branch
from
5e20cd3 to
b65164d
Compare
Xottab-DUTY
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just sprinkled some good old
[[fallthrough]].