OSX non-root user changes#45
Closed
shaun-rutherford wants to merge 35 commits intoOpenVoxProject:mainfrom
Closed
Conversation
Check if homebrew already exists to skip the homebrew install and sudo commands to allow non-root execution
Attempting to force tls_1.3
Changed: lib/vanagon/utilities.rb
additional directory check for homebrew install
Setting check for homebrew to core directory
Chown for MacOS directories
Sudo to mkdir for file-list-before-build and bill_of_materials
Setting bill_of_materials and file-list-before-build ownership to the current running user
setting chown to recursive on file-list-before-build
sudo chown root:root for the files after being compiled
… solve ownership issue with ruby
fileutils on Mac doesn't delete the actual directory itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all!
Please do a squash merge as this took a lot of testing to get right.
The following changes vanagon so that you can do OSX builds without being the root user.
The user executing the build does need to have sudo rights, but that does not have to be root which is standard Unix style security best practice.
I've also added a check that if you already have homebrew installed on your machine, vanagon will skip trying to install homebrew (which generates an error and stops the build) and instead changes ownership of the directories I could find interfere with the build process.