CMakeLists.txt and linker minor fixes #200
Conversation
Mionsz
added
the
maintainers review request
Mionsz
changed the title
|
@Mionsz Can you elaborate more why you're changing |
Mionsz
force-pushed
the
private/mlinkiew/cmake_fixes
branch
from
0799257
to
9e492d6
Compare
Due to minor limitations of check-pkg is had to introduce a distinction between libmcm_dp static and libmcm_dp dynamic library. But now when you pointed this out I could leave the naming as it was but introduce |
Mionsz
force-pushed
the
private/mlinkiew/cmake_fixes
branch
from
9e492d6
to
3309843
Compare
|
@ko80 I have changed the above mention. |
|
This all needs to be verified if sample apps work AND if FFmpeg MCM plugins work on single node. |
Build dependencies and linker fixes focus is on: - building all dependencies for mcm as a pre-build phase - address linker issues that required passing specific paths for libraries to be found under debian - lots of minor changes is between. Signed-off-by: Milosz Linkiewicz <[email protected]>
Mionsz
force-pushed
the
private/mlinkiew/cmake_fixes
branch
from
3309843
to
b21b131
Compare
| "${BUILD_DIR}/FFmpeg/configure" \ | ||
| --disable-doc \ | ||
| --disable-shared \ | ||
| --enable-static \ |
There was a problem hiding this comment.
Why do you change it from shared to static lib?
| target_link_libraries(media_proxy_lib PUBLIC m ${MTL_LIB} ${_REFLECTION} | ||
| ${_GRPC_GRPCPP} ${_PROTOBUF_LIBPROTOBUF} ${MEMIF_LIB} ${LIBFABRIC}) | ||
|
|
||
| add_executable(media_proxy ${proxy_srcs}) | ||
| target_link_libraries(media_proxy PRIVATE media_proxy_lib) | ||
| target_link_libraries(media_proxy PRIVATE media_proxy_lib -static-libgcc -static-libstdc++ -pthread -ldl ${LIBBPF}) |
There was a problem hiding this comment.
Do we really need those libraries in static version?
CMakeLists.txt and linker minor fixes focus is on: