[Hackathon] add basic xss template #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
requested changes
Feb 10, 2019
challenge_templates/xss/src/main.py
Outdated
|
|
||
| @app.route("/") | ||
| async def index(): | ||
| query = parse_qs(request.query_string) |
There was a problem hiding this comment.
4 space indents for this whole file
| import secrets | ||
| import asyncio | ||
|
|
||
| from urllib.parse import parse_qs |
There was a problem hiding this comment.
pep8 groupings. Put stdlib in one grouping at the top (even if from...), then 3rd party, then local libs
wbowling
commented
Mar 29, 2019
| pass | ||
|
|
||
| async def start_browser(url): | ||
| browser = await launch(**chromium_path(), args=["--no-sandbox"]) |
There was a problem hiding this comment.
This line stopped working on the ota vps, not sure why as it works locally in docker and on my vps. Changing it to just browser = await launch(args=["--no-sandbox"]) fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for a few upcoming challenges, might be useful to have as a template