Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scan metrics #184

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

TanUkkii007
Copy link

@TanUkkii007 TanUkkii007 commented Dec 1, 2017

Add scan metrics functions in the Scanner.

Following scan metrics are added. Those lists are part of the metrics from the official HBase client.

  • server-side metrics
    • ROWS_SCANNED
    • ROWS_FILTERED
  • client-side metrics
    • RPC_CALLS
    • MILLIS_BETWEEN_NEXTS
    • NOT_SERVING_REGION_EXCEPTION
    • BYTES_IN_RESULTS
    • REGIONS_SCANNED
    • RPC_RETRIES_METRIC_NAME

Integration tests are also included and checked with HBase 1.2.6.

Known issues

  • It seems the count of RPCs is different among HBase versions. I tested with HBase 0.94 and the number of RPCs is higher than 1.2.6. This fails the integration tests against 0.94.
  • Server-side metrics is supported for HBase 0.95 and higher. Tests about server-side metrics are skipped if the server-side metrics show zero value.

@TanUkkii007 TanUkkii007 force-pushed the feature/scanner-metrics branch from 71d089d to f09ed77 Compare December 1, 2017 10:39
@TanUkkii007
Copy link
Author

BTW, recently I talked about migration to asynchbase. Scan metrics I implemented in this PR are shown in my slides.
https://www.slideshare.net/TanUkkii/nonblocking-io-to-tame-distributed-systems-how-and-why-chatwork-uses-asynchbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant