Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix flag name typo #63

Closed

Conversation

SunburstEnzo
Copy link
Contributor

What

I noticed the flag in the Example project was using OEPNSWIFTUI instead of OPENSWIFTUI

How

Changed the flag name in Build Settings and ensured it was changed everywhere else (only ViewController.swift from what I could tell)
Screenshot 2024-04-06 at 2 24 59 pm

Let me know if I missed anything!

@SunburstEnzo SunburstEnzo changed the title Fix flag name typo Bug: Fix flag name typo Apr 6, 2024
Comment on lines 9 to 12
#if !OEPNSWIFTUI
#if !OPENSWIFTUI
import SwiftUI
#else
import OpenSwiftUI
Copy link
Member

@Kyle-Ye Kyle-Ye Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Would you mind also updating the order here in this PR?

#if OPENSWIFTUI
import OpenSwiftUI
#else
import SwiftUI
#endif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.42%. Comparing base (2b0da4d) to head (4056f2a).

❗ Current head 4056f2a differs from pull request most recent head 5a62b58. Consider uploading reports for the commit 5a62b58 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   13.42%   13.42%           
=======================================
  Files         185      185           
  Lines        4357     4357           
=======================================
  Hits          585      585           
  Misses       3772     3772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SunburstEnzo SunburstEnzo requested a review from Kyle-Ye April 6, 2024 14:08
Copy link
Member

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Kyle-Ye
Copy link
Member

Kyle-Ye commented Apr 6, 2024

The repo requires all commits to be signed. You need to recommitting the commits and force push to solve it.

See more info here https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

With GPG
@Kyle-Ye
Copy link
Member

Kyle-Ye commented Apr 6, 2024

Still showing as "Unverified". Maybe you need to upload your GPG key to your GitHub account.

image

@Kyle-Ye
Copy link
Member

Kyle-Ye commented Apr 6, 2024

I've cherry-picked your changes and will merge this in #67. (Reserving you as the commit author)

Close this PR. Sorry for that.

@Kyle-Ye Kyle-Ye closed this Apr 6, 2024
@Kyle-Ye Kyle-Ye mentioned this pull request Apr 6, 2024
@SunburstEnzo
Copy link
Contributor Author

No problem at all and apologies for the delay – should now show as Verified hopefully
Screenshot 2024-04-06 at 3 57 17 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants