-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix flag name typo #63
Bug: Fix flag name typo #63
Conversation
#if !OEPNSWIFTUI | ||
#if !OPENSWIFTUI | ||
import SwiftUI | ||
#else | ||
import OpenSwiftUI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Would you mind also updating the order here in this PR?
#if OPENSWIFTUI
import OpenSwiftUI
#else
import SwiftUI
#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 13.42% 13.42%
=======================================
Files 185 185
Lines 4357 4357
=======================================
Hits 585 585
Misses 3772 3772 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
The repo requires all commits to be signed. You need to recommitting the commits and force push to solve it. See more info here https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
With GPG
4056f2a
to
5a62b58
Compare
I've cherry-picked your changes and will merge this in #67. (Reserving you as the commit author) Close this PR. Sorry for that. |
What
I noticed the flag in the Example project was using
OEPNSWIFTUI
instead ofOPENSWIFTUI
How
Changed the flag name in Build Settings and ensured it was changed everywhere else (only
ViewController.swift
from what I could tell)Let me know if I missed anything!