Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Color implementation #166

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Update Color implementation #166

merged 13 commits into from
Nov 27, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Nov 27, 2024

No description provided.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 14.67066% with 285 lines in your changes missing coverage. Please review.

Project coverage is 20.95%. Comparing base (05d48cd) to head (6d0f9e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Graphic/Color/Color.swift 0.00% 72 Missing ⚠️
...es/OpenSwiftUICore/Graphic/Color/SystemColor.swift 0.00% 69 Missing ⚠️
.../OpenSwiftUICore/Graphic/Color/Color+CGColor.swift 0.00% 40 Missing ⚠️
.../OpenSwiftUICore/Graphic/Color/ColorResolved.swift 0.00% 39 Missing ⚠️
...enSwiftUICore/Graphic/Color/Color+ShapeStyle.swift 7.69% 36 Missing ⚠️
.../OpenSwiftUICore/Graphic/Color/RGBColorSpace.swift 51.85% 13 Missing ⚠️
...nSwiftUICore/Shape/ShapeStyle/ShapeStylePack.swift 0.00% 5 Missing ⚠️
...penSwiftUICore/Graphic/Color/ColorOperations.swift 0.00% 4 Missing ⚠️
...iftUICore/Data/Environment/EnvironmentalView.swift 0.00% 2 Missing ⚠️
...rces/OpenSwiftUICore/Graphic/Color/ColorView.swift 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   21.49%   20.95%   -0.55%     
==========================================
  Files         256      262       +6     
  Lines        8443     8723     +280     
==========================================
+ Hits         1815     1828      +13     
- Misses       6628     6895     +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 3dd8e6e into main Nov 27, 2024
8 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/color branch November 27, 2024 19:00
Dark-Existed pushed a commit to Dark-Existed/OpenSwiftUI that referenced this pull request Dec 9, 2024
* Update Color

* Add SystemColor

* Update header info

* Update ThreadUtils

* Add Color+CGColor

* Update Color.Resolved API

* Add Color + View support

* Update RGBColorSpace

* Add documentation for SystemColor

* Update ResolvedColor

* Update ColorProvider default implementation

* Update ColorResolved ResolvedPaint

* Fix Linux build issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant