Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logrus for logging and add log levels #51

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Use logrus for logging and add log levels #51

merged 3 commits into from
Sep 14, 2023

Conversation

bastianjoel
Copy link
Member

resolves #50

@bastianjoel bastianjoel added this to the 4.1 milestone Sep 11, 2023
@bastianjoel bastianjoel requested a review from peb-adr September 13, 2023 15:54
@peb-adr
Copy link
Member

peb-adr commented Sep 14, 2023

IMO the variable should be called OPENSLIDES_LOG_LEVEL so it can be used uniformly across the stack.
If the log level is to be changed for the search service alone, OPENSLIDES_LOG_LEVEL should be adjusted for the relevant container(s).

@peb-adr
Copy link
Member

peb-adr commented Sep 14, 2023

Ok, looks good to me.

@peb-adr peb-adr merged commit 890dd1f into OpenSlides:main Sep 14, 2023
1 check passed
@bastianjoel bastianjoel deleted the 50-logs branch September 14, 2023 14:07
peb-adr added a commit that referenced this pull request Sep 15, 2023
@peb-adr
Merge main into stable/4.0.x. Update 20230915
acdc1f2 
* commit '890dd1fd31aeadc60fdd65849a1c3cd84c3727ae':
  Use logrus for logging and add log levels (#51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peb-adr peb-adr peb-adr approved these changes

@rrenkert rrenkert Awaiting requested review from rrenkert

Assignees

@rrenkert rrenkert

@peb-adr peb-adr

Labels
clean up
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Add option to disable certain logs
3 participants
@bastianjoel @peb-adr @rrenkert