Update Meeting Info: change count structure levels #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a dummy structure level in parliament mode, too. |
bastianjoel
requested changes
Dec 9, 2024
| @@ -58,48 +63,43 @@ export class ListOfSpeakersControllerService extends BaseController<ViewListOfSp | |||
| * @returns A list, which entries are `SpeakingTimeStructureLevelObject`. | |||
| */ | |||
| public getSpeakingTimeStructureLevelRelation(): SpeakingTimeStructureLevelObject[] { | |||
| let listSpeakingTimeStructureLevel: SpeakingTimeStructureLevelObject[] = []; | |||
| const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); | |||
There was a problem hiding this comment.
Suggested change
| const map_for_aggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); | |
| const mapForAggregation = new Map<Id, SpeakingTimeStructureLevelObject>(); |
| follow: [ | ||
| { | ||
| idField: `meeting_user_id`, | ||
| fieldset: FULL_FIELDSET |
There was a problem hiding this comment.
Why do you need everything here? This can be extremely much.
There was a problem hiding this comment.
I only need user_id as far as I know.
|
I tried to fix the problems, but run into a speaker.user is no set error in non-parliament mode, I need to debug that. |
The autoupdate service needs some time to return the meeting_info_X subscription result. In this interval speaker.user is undefined.
bastianjoel
approved these changes
Dec 9, 2024
Elblinator
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Only non-parlamentarian modus:
- If the structure level are not preloaded somewhere else the table shows "no data"
(Repo: let someone speak, navigate to "Count completed requests to speak" > you see data, reload page > "no data" is shown) - please show the users who have no structure level in the table (same appearance as in the parlamentarian-modus but only people with no structure level at all are counted
Styling:
in parlamentarian-modus and non-parlamentarian-modus make "Without Structure Level" the font-style: italic;
Sorting:
Please sort the structure level alphabetically
With the exception of "Without Structure Level" please put that item at the end of the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4271
In non-parliament mode add the time to all structure levels of a speaker user.